human-essentials icon indicating copy to clipboard operation
human-essentials copied to clipboard

Correct monetary donations on the essentials bank dashboard

Open bobmazanec opened this issue 3 years ago • 5 comments

Summary

The org. dashboard's Product Drives section is currently tallying all monetary donations, it should only tally those from Diaper Drives. The manufacturer donations should show the money raise from manufacturer donations [money only, not in kind]

Details

For example, given 3 monetary donations in the filtered period

image

  • The Product Drives should show only $200
  • The Manufacturer Donations should show the $3,000 , in the same format as the product drive info.

image

Things we should know

Somewhat related to #2762 This started out as a question. The markup above , and the comments below up to August 2022 reflect that. This was initiated before the reworking of language to be inclusive of non-diaper products. The screenshots are from an earlier version, but should be self-explanatory.

Criteria for completion

  • [ ] Modify any tests regarding the product drive section to reflect showing only product drive donations
  • [ ] Add test for showing manufacturer donation monetary donations.
  • [ ] Fix the product drive numbers
  • [ ] add the manufacturer monetary donations to the dashboard $ NNNN raised during the period 01 Jan to 31 Dec

bobmazanec avatar Feb 23 '22 15:02 bobmazanec

Did your pull request #2762 fix this?

seanmarcia avatar Mar 10 '22 21:03 seanmarcia

Nope.

bobmazanec avatar Mar 11 '22 21:03 bobmazanec

Should we change this issue to help wanted?

seanmarcia avatar Mar 23 '22 13:03 seanmarcia

Looking more for discussion/conclusion than coding/effort, I think. As discussed previously, I suspect Dashboard details aren't as urgent for stakeholders as other features. 🤷‍♂️

bobmazanec avatar Mar 23 '22 17:03 bobmazanec

reworking this so that it's a better format to go forward

cielf avatar Aug 07 '22 19:08 cielf

This issue has been inactive for 245 hours (10.21 days) and will be automatically unassigned after 115 more hours (4.79 days).

github-actions[bot] avatar Sep 07 '22 00:09 github-actions[bot]