Allow bank users to mark partner users as a admins

[edwinthinks]

Summary

Related to #2474 which details a request to enable admin partner users to revoke access to non-admin partner users within their agency. This issue relates to giving Bank users the ability to set partner users as admins.

Blocked by #2471 which would give Bank users the ability to see partner users within an agency.

There should be some button or mechanism that allows Bank users to mark partner users within an agency they work with to an admin. That admin would then be able to do things like #2474 .

Things to Consider

We have this pattern on the bank side where organizations are able to make people admins, set them as users, or deactivate them. We should have a similar pattern as the banks as seen below:

Criteria for Completion

• [ ] As a bank user, I can label a partner user as an admin of their partner agency
• [ ] As a bank user, I can remove partner users as admins of their partner agency
• [ ] The label or information that denotes a partner user as an admin should be in the database. Preferable to add a simple boolean field like agency_admin on Partners::User

Bonus Points

• [ ] Add in the ability of banks to deactivate a user.

[markcyen]

Hey @edwinthinks, would it be something like the following you were thinking?

[github-actions[bot]]

This issue has been inactive for 246 hours (10.25 days) and will be automatically unassigned after 114 more hours (4.75 days).

[github-actions[bot]]

This issue has been inactive for 365 hours (15.21 days) and is past the limit of 360 hours (15.00 days) so is being unassigned.

[seanmarcia]

@markcyen Story has been updated if you are still interested!

[dorner]

If we do end up using something like pundit as suggested in #2787, we probably should wait on this until we have that done, since we would want to use pundit's roles / permissions rather than rolling our own.

[seanmarcia]

That is probably the best way to go but the pundit implementation is a pretty major lift. This one, basically, just requires setting a single boolean field partner_admin or something similar and then using the discard gem like other models do. Not sure which is the best way to go. If you are able to attend an essentials office hour we should discuss the user model/pundit/etc stuff.

[dorner]

I'd love to but unfortunately they're always on Saturday afternoon, which I can't attend for religious reasons :(

[edwinthinks]

I think this is blocked by our merger of the two DBs. Our goal appears to be to start simplify things greatly so instead of building as it was written, we ought to think about how this feature would be implemented given we use 1 DB.

Another interesting tool, I haven't used yet is https://github.com/RolifyCommunity/rolify which could be useful in conjunction with Pundit.

[cielf]

Identified as high priority in July 13 2022 partnerbase working group meeting. Probably related to Daniel's current work.

[github-actions[bot]]

This issue has been inactive for 240 hours (10.00 days) and will be automatically unassigned after 120 more hours (5.00 days).

[github-actions[bot]]

This issue has been inactive for 360 hours (15.00 days) and is past the limit of 360 hours (15.00 days) so is being unassigned.