Case contact details ux improvements 5896

[josephmsmith]

What github issue is this PR for, if any?

Resolves #5896

What changed, and why?

3 main changes were made to the UX around creating contact details in order to improve UX and create a better experience for recorder.

• [x] Marked "Was contact made?" and "How was contact made?" as required by adding asterisks instead of marking "Record Contact Details" as mandatory. This ensures User knows what specific fields needed to be added to complete submission.
• [x] Add server side validation NOT client side (required JavaScript) to the fields. Currently if there is an error it reloads the page and you must scroll all the way down. The scrolling feature was not modified.
• [x] Contact Type Selection: Sort the options in the dropdown by recency where contact types that were never used remain at the bottom of the options.

How is this tested? (please write tests!) 💖💪

added rspec testing to case_contact_decorator spec to test new method

Screenshots please :)

[github-actions[bot]]

This PR has been open for a long time without any pushes or comments! What's up?

[josephmsmith]

Hi @FireLemons apologies for the delay here. Let's chat about this tomorrow during office hours and I can get this restarted!

[github-actions[bot]]

This PR has been open for a long time without any pushes or comments! What's up?