casa icon indicating copy to clipboard operation
casa copied to clipboard

Create A Follow Up Button on Each Section of the Emancipation Checklist

Open CovenantHuman opened this issue 4 years ago • 3 comments

What type(s) of user does this feature affect?

  • volunteers
  • supervisors
  • admins

Description Add a Follow-up Button like the one displayed on case contacts to each individual section of the Emancipation Checklist. This Button should work in the same way as it does on case contacts, where it offers the individual requesting the follow-up a textbox to elaborate on the follow-up required and sends a notification to the volunteer in charge of the case.

Screenshots of current behavior, if any
Follow-up behavior on a case-contact as a guide: Follow up Behavior

QA Login Details:
Link to QA site

Login Emails:

password for all users: 123456

CovenantHuman avatar Oct 05 '21 02:10 CovenantHuman

Hi, I was thinking about picking this issue, and I found out that the Emancipation Checklist page is very different from the case contacts one. There's no space for a follow up button there unless I open the tab: Screenshot 2021-10-08 at 15 39 03

Do you have any designs or sketches on how the button should look on the page?

VictorPS avatar Oct 08 '21 14:10 VictorPS

Hi, I was thinking about picking this issue, and I found out that the Emancipation Checklist page is very different from the case contacts one. There's no space for a follow up button there unless I open the tab: Screenshot 2021-10-08 at 15 39 03

Do you have any designs or sketches on how the button should look on the page?

Hi! Sorry for the late reply- we don't have a mockup, please just use your judgement on spacing.

compwron avatar Mar 30 '22 00:03 compwron

Hey - haven't seen much activity on this one for a few years. I'll take a crack at it.

davetheknave8 avatar May 23 '23 00:05 davetheknave8

This doesn't seem like it is still being worked on. I'm going to take a stab at it. It is my first issue but I think I can do this one.

acasarsa avatar Mar 29 '24 14:03 acasarsa

I have some notes on what may need to be changed to get this feature implemented. Currently, the Followup model is intricately linked with CaseContact, limiting its applicability to other entities such as items in the emancipation checklist. To extend the functionality of followups to broader use cases, several architectural changes are needed:

  1. Generalize the Followup Model: The Followup model could be reworked to allow associations with entities beyond CaseContact. Implementing a polymorphic association is a viable strategy, enabling a Followup to be linked with any model, such as CasaCase or a specific Volunteer (User). This would enhance its flexibility and reuse across different contexts.
  2. Update Controllers for Reusability: The current controller and its organizational structure are tailored specifically to CaseContact followups. We'd need to either adapt this controller to handle followups for various entities through a more generic approach or create a new controller dedicated to managing followups for cases and emancipation checklist items. This rework will involve deciding on a unified or context-specific controller strategy to maintain clean and maintainable code. *it should be noted at the moment followup_controller is within a case_contact dir. We can investigate whether keeping that structure vs a single controller is best. Perhaps using controller concerns would be helpful to avoid reaping logic.
  3. Revise Followup Routing Strategy: Introducing a more versatile routing strategy or reworking the existing routes to accommodate the creation of followups across different entities is needed.
  4. Add Flexiblility to Notification System: Adding flexibility here would be great, this could be a pr inself really. But for this issue the main thing is to figure out who should be notified about the checklist followup.
  5. Update to javascript/jquery files: currently these capture a case_contact_id to make a POST request for creating a CaseContact followup. Could generalize this script to work for different id's or make a separate one.

!! *There may be other areas but these were the ones that I've noticed so far.

acasarsa avatar Apr 02 '24 19:04 acasarsa

Mallory and I talked to stakeholder Jocie about this today - Probably still wanted, there may be other ways to solve Primarily asked for by a CASA other than Jocie's - let's dig out who it was if possible - maybe email stakeholders to ask? Jocie: There were talks about adding emancipation items to the end of a case contact... that might solve the problem? If volunteers were prompted every time they did a case contact?

compwron avatar Apr 05 '24 18:04 compwron

@compwron adding emancipation items to the _case_contact.html.erb would make this feature substantially easier to implement. The tricky but workable part would be changing how there can only be 1 requested followup at a time.

acasarsa avatar Apr 07 '24 20:04 acasarsa

This issue has been inactive for 243 hours (10.13 days) and will be unassigned after 117 more hours (4.88 days). If you have questions, please

If you are still working on this, comment here to tell the bot to give you more time

github-actions[bot] avatar Apr 18 '24 00:04 github-actions[bot]

Part 1 of this epic is complete.

On Wed, Apr 17, 2024 at 8:15 PM github-actions[bot] < @.***> wrote:

This issue has been inactive for 243 hours (10.13 days) and will be unassigned after 117 more hours (4.88 days). If you have questions, please

If you are still working on this, comment here to tell the bot to give you more time

— Reply to this email directly, view it on GitHub https://github.com/rubyforgood/casa/issues/2699#issuecomment-2062760882, or unsubscribe https://github.com/notifications/unsubscribe-auth/AEH2QV6JBPNUKNACSN7U2K3Y54GBTAVCNFSM5FKXCM42U5DIOJSWCZC7NNSXTN2JONZXKZKDN5WW2ZLOOQ5TEMBWGI3TMMBYHAZA . You are receiving this because you were assigned.Message ID: @.***>

acasarsa avatar Apr 19 '24 13:04 acasarsa

This issue has been inactive for 251 hours (10.46 days) and will be unassigned after 109 more hours (4.54 days). If you have questions, please

If you are still working on this, comment here to tell the bot to give you more time

github-actions[bot] avatar Apr 30 '24 00:04 github-actions[bot]

This issue has been inactive for 371 hours (15.46 days) and is past the limit of 360 hours (15.00 days) so is being unassigned.You’ve just been unassigned from this ticket due to inactivity – but feel free to pick it back up (or a new one!) in the future! Thank you again for your contribution to this project.

github-actions[bot] avatar May 05 '24 00:05 github-actions[bot]

I am closing this as old. We may bring it back in a different form.

compwron avatar May 05 '24 20:05 compwron

assigning for file list reference while i work on the rest of the polymorphic migration process pr's. hoping to get part 2 started this weekend.

acasarsa avatar May 10 '24 16:05 acasarsa