Flaredown icon indicating copy to clipboard operation
Flaredown copied to clipboard

Entering zip code often gets wrong country

Open bklang opened this issue 4 years ago • 1 comments

I have noticed this in staging: when I enter a zip code for 19013, I get a city in Italy, and when I enter zip code 10001 it comes back as Vilnius, Latvia. Consider:

  • The user has already told us their country via profile in many cases, so use that when available
  • This behavior may change when we fix #535
  • When in doubt, is there a default we should use? United States?

bklang avatar Oct 15 '21 21:10 bklang

This is a very annoying issue that a lot of users run into!

I believe (far from sure) that we separately query Google maps to turn the user-entered string into a proper location before feeding it to the weather API. That easily could have changed since initial implementation however.

When in doubt, is there a default we should use? United States?

I would recommend warning the user and resetting to the original location (or absence of location) rather than defaulting. Non-local weather reports won't be useful to them, and we'd want them to know that the location didn't take so they can try to remedy it.

lmerriam avatar Oct 19 '21 15:10 lmerriam