psych icon indicating copy to clipboard operation
psych copied to clipboard

Implement emoji support

Open ghost opened this issue 4 years ago • 3 comments

This pull request addresses an issue with 4 byte unicode characters. It uses code from a pr which was filed against tarantool in response to https://github.com/tarantool/tarantool/issues/4090.

I'm well aware that this probably should belong to the libyaml repository. I wanted to open it here first to have a base to work from. Response time in libyaml seems to be somewhat long and thus I think this is a feature we should implement asp. This could unlock faster automated translations in Rails(as I18n hands over yaml generation to this gem).

ghost avatar Jun 09 '21 07:06 ghost

Fixes #371 and https://github.com/glebm/i18n-tasks/issues/291 ?

coorasse avatar Jun 09 '21 07:06 coorasse

It should! We can add some more tests to ensure that it works for the most commonly used Unicode characters

Liberatys avatar Jun 09 '21 07:06 Liberatys

Seems to break CI 😅. I really like the idea of supporting emoji, but I'm somewhat worried about supporting effectively a fork of libyaml. But I really do like the idea of supporting emoji 🤔

tenderlove avatar Aug 04 '21 16:08 tenderlove