openssl icon indicating copy to clipboard operation
openssl copied to clipboard

Use X509_ALGOR_get0() accessor for X509_ALGOR

Open botovq opened this issue 2 years ago • 4 comments

While the struct is currently still public in OpenSSL, there has been an accessor since OpenSSL 0.9.8h. It would be nice if this accessor could be used so that the struct can be made opaque at some point in the future.

botovq avatar Oct 19 '23 20:10 botovq

Of course there had to be a const change in the OpenSSL 1.1 cycle. I should have thought of that. Sorry about hat. Presumably this means that we need a define that is const for OpenSSL >= 1.1 and empty otherwise. This is becoming more cumbersome than I'd hoped it to be...

botovq avatar Oct 19 '23 21:10 botovq

Makes sense to me.

I'm hoping to remove OpenSSL 1.0.2 support in our next release as the last significant user of it (RHEL 7 - on which we still test Ruby on rubyci.org) will reach EOL next year. Since this is not urgent, let's merge it after that.

rhenium avatar Oct 25 '23 20:10 rhenium

On Wed, Oct 25, 2023 at 01:10:27PM -0700, Kazuki Yamaguchi wrote:

Makes sense to me.

I'm hoping to remove OpenSSL 1.0.2 support in our next release as the last significant user of it (RHEL 7 - on which we still test Ruby on rubyci.org) will reach EOL next year. Since this is not urgent, let's merge it after that.

Ok, great. Then I'll not ponder further complications. Thank you!

botovq avatar Oct 25 '23 20:10 botovq