debug icon indicating copy to clipboard operation
debug copied to clipboard

🔊 Make INFO the default logging level

Open marianosimone opened this issue 3 years ago • 2 comments

As proposed by @ko1 in https://github.com/ruby/debug/pull/750, make INFO the default level, so we can move down some messages like:

DEBUGGER:  BP - Line  /<redacted>.rb:<line> (call) is activated.

At the same time, there seem to be a lot of current logs that are more suited for the DEBUG level than INFO, so I'm moving those down to not make the new default more noisy.

marianosimone avatar Sep 16 '22 17:09 marianosimone

Thank you for the patch. Viewing the changes, I want additional info command :p

    1. Convenience information
    • enabling breakpoint
    • forking process
    1. Less-convenience information (but sometimes it is useful)
    • loading a ruby file
    1. debugger Internal events

I agree 1 and 3 is INFO and DEBUG. Not sure for 2. Your patch makes 2 as DEBUG (and I agree almost it is enough). hmm.

The current design

  • WARN - for 1
  • INFO - for 2
  • DEBUG - for 3

is better? Let me take a time for consideration. Another tools/debuggers examples are also welecome.

ko1 avatar Sep 16 '22 21:09 ko1

I think ERROR, WARN, INFO and DEBUG are pretty standard in terms of logging levels, and they roughly match with my patch here. I believe it would be weird to add a new level in between them.

Feel free to edit this PR as you see fit to match your logging philosophy, though :)

marianosimone avatar Sep 16 '22 22:09 marianosimone

fix with #823

ko1 avatar Nov 22 '22 20:11 ko1