debug icon indicating copy to clipboard operation
debug copied to clipboard

Improve RUBYOPT's handling in tests

Open st0012 opened this issue 1 year ago • 2 comments

When debugging the issue related to https://github.com/ruby/irb/pull/919, I noticed that debugger tests don't respect the IRB version I specified in the Gemfile. This is because console tests force override the RUBYOPT env, which will remove the -rbundler/setup injected by bundler.

Additionally, if tests use run_rdbg with the rubyopt option, the RUBYOPT will be overridden yet again.

So in this commit I did 2 improvements:

  1. run_rdbg should append instead of override RUBYOPT
  2. If tests are executed with bundler, we also run the debugger in PTY process with bundler by appending -rbundler/setup to RUBYOPT

st0012 avatar Apr 11 '24 15:04 st0012

Launchable Report

:x: Test session #2825363 failedos:ubuntu-latest test_task:test_protocoldetails on CI
:bell: no issues :heavy_multiplication_x:1 test failed :heavy_check_mark:63 tests passed

Passed test sessions

:white_check_mark: Test session #2825347 passed os:ubuntu-latest test_task:test_testdetails on CI
:white_check_mark: Test session #2825349 passed os:ubuntu-latest test_task:test_testdetails on CI
:white_check_mark: Test session #2825350 passed os:ubuntu-latest test_task:test_testdetails on CI
:white_check_mark: Test session #2825351 passed os:ubuntu-latest test_task:test_testdetails on CI
:white_check_mark: Test session #2825352 passed os:ubuntu-latest test_task:test_testdetails on CI
:white_check_mark: Test session #2825353 passed os:ubuntu-latest test_task:test_testdetails on CI
:white_check_mark: Test session #2825355 passed os:ubuntu-latest test_task:test_protocoldetails on CI
:white_check_mark: Test session #2825357 passed os:ubuntu-latest test_task:test_protocoldetails on CI
:white_check_mark: Test session #2825358 passed os:ubuntu-latest test_task:test_protocoldetails on CI
:white_check_mark: Test session #2825359 passed os:ubuntu-latest test_task:test_protocoldetails on CI
:white_check_mark: Test session #2825360 passed os:ubuntu-latest test_task:test_protocoldetails on CI
:white_check_mark: Test session #2825373 passed os:ubuntu-latest test_task:test_protocoldetails on CI
:white_check_mark: Test session #2825407 passed os:ubuntu-latest test_task:test_consoledetails on CI
:white_check_mark: Test session #2825408 passed os:ubuntu-latest test_task:test_consoledetails on CI
:white_check_mark: Test session #2825409 passed os:ubuntu-latest test_task:test_consoledetails on CI
:white_check_mark: Test session #2825412 passed os:ubuntu-latest test_task:test_consoledetails on CI
:white_check_mark: Test session #2825413 passed os:ubuntu-latest test_task:test_consoledetails on CI
:white_check_mark: Test session #2825414 passed os:ubuntu-latest test_task:test_consoledetails on CI
:white_check_mark: Test session #2825423 passed os:macos-latest test_task:test_consoledetails on CI
:white_check_mark: Test session #2825444 passed os:macos-latest test_task:test_consoledetails on CI
:white_check_mark: Test session #2825457 passed os:macos-latest test_task:test_consoledetails on CI
:white_check_mark: Test session #2825468 passed os:ubuntu-latest test_task:test_consoledetails on CI

Build: refs_pull_1097_merge_ec352d20ea65c331150d36bc214e196178f619ee

launchable-app[bot] avatar Apr 11 '24 15:04 launchable-app[bot]

Ruby head is failing because the commit it uses doesn't include the workaround in https://github.com/ruby/irb/pull/919 yet. Once it picks a newer commit it should pass.

st0012 avatar Apr 11 '24 15:04 st0012

Thank you.

ko1 avatar Dec 17 '24 20:12 ko1