debug icon indicating copy to clipboard operation
debug copied to clipboard

Use default `max_lines` when calling `up` & `down`

Open HeyNonster opened this issue 1 year ago • 4 comments

Description

Both up and down only show 1 source line when called, I think it would be more useful if they provided more context. This removes the max_lines: 1 kwarg when they call show_src. max_lines in show_src will default to CONFIG[:show_src_lines]^1.

Big thanks to @st0012 for showing me and @bquorning where this behavior is defined.

HeyNonster avatar Apr 04 '24 18:04 HeyNonster

I want to second this proposal as I also often need to chain whereami after moving to a different frame, which IMO is not the best user experience in most cases.

st0012 avatar Apr 04 '24 19:04 st0012

Also probably useful to note that byebug displays more lines by default making it quite a difference switching from byebug to debug:

https://github.com/ruby/debug/assets/47484308/5f2174b9-1264-4753-be71-14203977c69f

HeyNonster avatar Apr 05 '24 07:04 HeyNonster

Launchable Report

:x: Test session #2907805 failedos:ubuntu-latest test_task:test_protocoldetails on CI
:bell: no issues :heavy_multiplication_x:1 test failed :heavy_check_mark:63 tests passed

:x: Test session #2907807 failedos:ubuntu-latest test_task:test_protocoldetails on CI
:bell: no issues :heavy_multiplication_x:1 test failed :heavy_check_mark:63 tests passed

Passed test sessions

:white_check_mark: Test session #2907791 passed os:ubuntu-latest test_task:test_testdetails on CI
:white_check_mark: Test session #2907792 passed os:ubuntu-latest test_task:test_testdetails on CI
:white_check_mark: Test session #2907793 passed os:ubuntu-latest test_task:test_testdetails on CI
:white_check_mark: Test session #2907794 passed os:ubuntu-latest test_task:test_testdetails on CI
:white_check_mark: Test session #2907796 passed os:ubuntu-latest test_task:test_testdetails on CI
:white_check_mark: Test session #2907798 passed os:ubuntu-latest test_task:test_testdetails on CI
:white_check_mark: Test session #2907799 passed os:ubuntu-latest test_task:test_protocoldetails on CI
:white_check_mark: Test session #2907800 passed os:ubuntu-latest test_task:test_protocoldetails on CI
:white_check_mark: Test session #2907801 passed os:ubuntu-latest test_task:test_protocoldetails on CI
:white_check_mark: Test session #2907803 passed os:ubuntu-latest test_task:test_protocoldetails on CI
:white_check_mark: Test session #2907815 passed os:ubuntu-latest test_task:test_protocoldetails on CI
:white_check_mark: Test session #2907818 passed os:macos-latest test_task:test_consoledetails on CI
:white_check_mark: Test session #2907822 passed os:macos-latest test_task:test_consoledetails on CI
:white_check_mark: Test session #2907823 passed os:ubuntu-latest test_task:test_consoledetails on CI
:white_check_mark: Test session #2907824 passed os:ubuntu-latest test_task:test_consoledetails on CI
:white_check_mark: Test session #2907825 passed os:ubuntu-latest test_task:test_consoledetails on CI
:white_check_mark: Test session #2907826 passed os:macos-latest test_task:test_consoledetails on CI
:white_check_mark: Test session #2907829 passed os:ubuntu-latest test_task:test_consoledetails on CI
:white_check_mark: Test session #2907831 passed os:ubuntu-latest test_task:test_consoledetails on CI
:white_check_mark: Test session #2907834 passed os:ubuntu-latest test_task:test_consoledetails on CI
:white_check_mark: Test session #2907857 passed os:ubuntu-latest test_task:test_consoledetails on CI

Build: refs_pull_1094_merge_b1963e7b72554c9672900ba046c3088598955488

launchable-app[bot] avatar May 16 '24 04:05 launchable-app[bot]

Seems the protocol tests are flaky: https://github.com/ruby/debug/pull/1060

HeyNonster avatar May 19 '24 03:05 HeyNonster

Maybe we need to introduce another configuration.

ko1 avatar Dec 17 '24 20:12 ko1