grape icon indicating copy to clipboard operation
grape copied to clipboard

1.6.0 -> 1.6.1 contains breaking change

Open ro-savage opened this issue 4 years ago • 8 comments

Our automated tests are showing

rake aborted!
NameError: uninitialized constant Grape::Validations::Base

It appears this commit https://github.com/ruby-grape/grape/commit/937b2fc8a7081c5eb74ff8a4a760e30ebabbd780 changed the path from Grape::Validations::Base to Grape::Validations::Validators:Base

ro-savage avatar Jan 04 '22 20:01 ro-savage

yeah, sorry for that.

sadly, after the release I noticed that the UPGRADING.md had not been updated in #2200. so I didn't expect any breaking change from such refactoring.

I'm closing, there is nothing we can do here.

dm1try avatar Jan 04 '22 22:01 dm1try

though, we can create a patch for compatibility with 1.6.0 and up a minor version

Grape::Validations::Base = Grape::Validations::Validators:Base

dm1try avatar Jan 04 '22 22:01 dm1try

@dm1try - We've updated our codebase to use Grape::Validations::Validators:Base But I think it make sense to release 1.6.3 that contains this - so that the latest 1.6.x isn't a breaking change from 1.6.0

ro-savage avatar Jan 05 '22 02:01 ro-savage

@dm1try - We've updated our codebase to use Grape::Validations::Validators:Base But I think it make sense to release 1.6.3 that contains this - so that the latest 1.6.x isn't a breaking change from 1.6.0

This was a miss. Care to PR this fix @ro-savage ?

dblock avatar Jan 05 '22 02:01 dblock

@dblock - Unfortunately I am not a ruby developer, I actually wouldn't know where to put the alias.

ro-savage avatar Jan 05 '22 03:01 ro-savage

:( Breaking change in a patch version. This does not only affect Grape::Validations::Base, but also users who extended existing built-in validators or compositions of it. This is even worse for external package maintainers who rely on the constants.

Jack12816 avatar Feb 17 '22 06:02 Jack12816

Agreed. Can someone please PR a fix? @dm1try ?

dblock avatar Feb 17 '22 22:02 dblock

@dblock take a look at #2244

dm1try avatar Feb 17 '22 23:02 dm1try