grape icon indicating copy to clipboard operation
grape copied to clipboard
verified publisher icon ruby-grape

Report endpoint_call.grape which includes the whole stack

Open Kukunin opened this issue 5 years ago • 5 comments

Fixes #2010

To keep the backward compatibility, I introduced a new event. The integration works fine in my project with this change.

Kukunin avatar Mar 17 '20 12:03 Kukunin

Rubocop limit was increased previously too https://github.com/ruby-grape/grape/commit/28d34ee19bdf70cb8471535b4c76312d440a63a6#diff-74423563ec7c74f4cb7f74689b49e7c1R47, and I believe to refactor it, a person should a better insight about grape than I have.

So I increased limit by 3 lines too

Kukunin avatar Mar 17 '20 12:03 Kukunin

Thanks for the review. Will try to fix the issues later today or tomorrow

Kukunin avatar Mar 17 '20 14:03 Kukunin

@Kukunin bumping myself on top of your list!

dblock avatar Oct 05 '22 15:10 dblock

hi @dblock. do you mean that it'd be good to finalize and get this PR merged? If yes, then it's something I can do

Kukunin avatar Oct 05 '22 15:10 Kukunin

hi @dblock. do you mean that it'd be good to finalize and get this PR merged? If yes, then it's something I can do

Yes, please! Rebase & al. I know it's old but I think we still want it.

dblock avatar Oct 05 '22 15:10 dblock