Raphael Gaschignard

Results 177 comments of Raphael Gaschignard

@IanManske is it possible you didn't hit "confirm" on your review? Not seeing any comments

Thanks for pointing out `Arc::into_inner` and handling ownership that way! I reworked the code so that we can just rely on Rust's ownership and the single `expect` call to get...

@kubouch the reasoning for the property tests: - the property test helped me find several bugs (basically around `parent_deletions`). Stuff I think more diligent people would find without the property...

Regarding the panicking to avoid cloning... I do think we should treat an unintentional clone as a fatal error here. The performance is just so bad if you have cloning...

Would you be against me checking in the property test into `crates/nu-protocol/src/engine/property_test.rs`, where if, say, the `RUN_PROPERTY_TESTS` env var isn't set, then the test just returns immediately? I'd like to...

actually scratch that, I'll just delete the property test. Not that interested in fighting an uphill battle on this, and I've convinced myself the changes are OK. I'll generate some...

OK I moved the property tests to a new file (`property_tests.rs`). I put this in `crates/nu-protocol/src/engine`, and made it only compile if you activate the `proptest` feature. It feels like...

Sorry, I was out and about last week. I'm trying to rebase off of the changes in #11860, and the entire control flow got changed up. Will ruminate on this...

Actually it's not clear to me if stack parents are workable in this unwinding model. I want to checkpoint the stacks for potential unwinds, but I want to apply modifications...

Alright, successfully rebased. This involved adding yet another Stack operation (`Stack::with_changes_from_child`) to do the whole "apply changes from child back to the parent". So at a high level what is...