testSignificanceNLP

testSignificanceNLP copied to clipboard

Possible bug

5

In lines [78](https://github.com/rtmdrr/testSignificanceNLP/blob/08fc2dbf4dc7d1b89d5830081d13baa199cdb22d/testSignificance.py#L78) and [100](https://github.com/rtmdrr/testSignificanceNLP/blob/08fc2dbf4dc7d1b89d5830081d13baa199cdb22d/testSignificance.py#L100), shouldn't the sign be flipped? i.e. increment r if delta > 2*orig_delta. That's according to the Berg-Kirkpatrick et al. (2012) paper, unless I'm misunderstanding something....

trangham283

Thanks for writing this code! It would be great if you could add an open-source license so that we know whether it's ok to copy the code into other repos.

daphnei

data file example

2

Hello, Thank you for the great work ! I just read the paper and took a look to the code. Could it be possible to have an example of (score?)...

ghost

The [flowchart](https://ie.technion.ac.il/~roiri/papers/ACL-2018-sig-cr.pdf) presented in the paper (Figure 1) and the talk is very helpful and I think it will have great impact by simplifying the process for people who struggle...

danielhers