Robert Timms comments

Results 132 comments of


                                            Robert Timms

Maximum number of decreased steps occurred at t=0.0. Try solving the model up to this time only or reducing dt_max (currently, dt_max=12.199448838323828) and/or reducing the size of the time steps or period of the experiment.[Bug]:

@Ma2922 was this resolved?

[Bug]: Installing `PyBaMM` on `M1` chip fails (both `pip` and install from source)

FYI the following worked for me on Python 3.9.13 + M2 Macbook Air + MacOS 13.2 1. Installed Python 3.9.13 universal installer from [here](https://www.python.org/ftp/python/3.9.13/python-3.9.13-macos11.pkg) 2. Created a virtual env using...

Add `max_step` arg in `basesolver`

@arjxn-py are you still working on this?

Changed fundamental SEI variable from thickness to concentration

@DrSOKane, thanks for this! have you had any luck in debugging the notebook? would be good to get this in for the next release

Implemented `non_linear_time`, an array of time as an input to `step` function

You should always have to pass `dt`, and `t_eval` should be the optional argument. If `t_eval` is `None` then set `t_eval = np.linspace(0, dt, 2)` (this is the same as...

Implemented `non_linear_time`, an array of time as an input to `step` function

> Why not just require t_eval (and no dt) so that the API matches solve ? Happy with this too, but `step` was kind of intended to be "step this...

Implemented `non_linear_time`, an array of time as an input to `step` function

thanks @prady0t looks great! can you add a changelog entry then this is good to go

[Bug]: Suface form effective conductivity in separator

@TomTranter any update on this?

Issue 3114 check coord

> I have added the final else as suggested. But I had a try and still cannot write a proper test for the divergence as it will require to define...

Issue 3114 check coord

thanks @kratman, i like this approach as we check coordinates a few times in that file, so will reduce duplication too