rticonnextdds-examples icon indicating copy to clipboard operation
rticonnextdds-examples copied to clipboard

Python async pub example

Open xFrenchy opened this issue 3 years ago • 2 comments

Summary

Python example displaying async publication

Details and comments

!important! This example is not ready yet, creating initial pull request for review purposes. Here is a list of things to review: -Idl file and class cannot be called "async" for python since it's a keyword. Naming the struct async and running rtiddsgen won't cause an error, however you won't be able to "from async import async". I have renamed it to async_type. Let me know if this should be approached differently -When checking the history depth with Admin Console for the DataWriter, it shows a depth of 1 when it should be 12. This is observable when setting the QoS via XML and/or setting it programatically -When creating a flow controller, I'm not sure what FlowController::FIXED_RATE_NAME is and what the python equivalent would be, for now I've created a flow controller without specifying a name

Checks

  • [ ] I have updated the documentation accordingly.
  • [x] I have read the CONTRIBUTING document.

xFrenchy avatar Sep 29 '22 03:09 xFrenchy

You should now target master instead of develop, since this example will work with Connext 7.0.0

alexcamposruiz avatar Oct 14 '22 15:10 alexcamposruiz

Hi @xFrenchy ! Can you apply the black formatting to this example?

You can run:

pip install black==22.3.0
black -l 79 --preview <file or directory>

lulivi avatar Oct 18 '22 17:10 lulivi

The compilation is starting. Take a look here.

github-actions[bot] avatar Jan 21 '23 03:01 github-actions[bot]

I applied black formatting (I think). I left a few notes in the publisher and subscriber files of things that I've found that I think are problematic. Right now the most problematic is the subscriber throwing an exception when shutting down the application. Otherwise I think it follows the C# example better than the previous attempt. I added an additional argument to use the QoS file or not. I didn't see this implemented in the C# example though. I see the variable, but I never see an argument or a way to toggle that variable in the example.

xFrenchy avatar Jan 21 '23 03:01 xFrenchy

Everything is OK. Thank you for the PR!

github-actions[bot] avatar Jan 21 '23 04:01 github-actions[bot]

The compilation is starting. Take a look here.

github-actions[bot] avatar Jan 25 '23 00:01 github-actions[bot]

The compilation is starting. Take a look here.

github-actions[bot] avatar Jan 25 '23 00:01 github-actions[bot]

Everything is OK. Thank you for the PR!

github-actions[bot] avatar Jan 25 '23 00:01 github-actions[bot]

Everything is OK. Thank you for the PR!

github-actions[bot] avatar Jan 25 '23 00:01 github-actions[bot]

The compilation is starting. Take a look here.

github-actions[bot] avatar Jan 25 '23 17:01 github-actions[bot]

The compilation is starting. Take a look here.

github-actions[bot] avatar Jan 25 '23 17:01 github-actions[bot]

Everything is OK. Thank you for the PR!

github-actions[bot] avatar Jan 25 '23 18:01 github-actions[bot]

Everything is OK. Thank you for the PR!

github-actions[bot] avatar Jan 25 '23 18:01 github-actions[bot]