leaflet icon indicating copy to clipboard operation
leaflet copied to clipboard

add tileOptions() to addRasterImage()

Open eduardszoecs opened this issue 7 years ago • 6 comments

This is a fix for #507 and deals more generally with tileOptions in addRasterImage(). The issue also links to other related issues in downstream packages.

The PR is backward compatible and raises a deprecation warning for the now overfluous arguments opacity and attribution.

PR task list:

  • [x] Update NEWS
  • [x] Add tests (if appropriate) [not appropriate? didn't find any existing tests]
  • [x] Update documentation with devtools::document()

eduardszoecs avatar Apr 01 '18 12:04 eduardszoecs

but you've directly changed inst/htmlwidgets/leaflet.js which is not the way to go about it. inst/htmlwidgets/leaflet.js is now auto generated and should not be directly edited. You need to change src/javascript/methods.js and then run grunt build from the project root.

I think this applies also for this PR (sorry for that) :( Will fix asap.

eduardszoecs avatar Apr 02 '18 12:04 eduardszoecs

running grunt build doesn't change anything, so PR is fine (=my manual changes to inst/htmlwidgets/leaflet.js seem to reflect grunt build).

eduardszoecs avatar Apr 02 '18 22:04 eduardszoecs

Hi @EDiLD

Could you ...

" 2. Ensure that you have signed the individual or corporate contributor agreement as appropriate. You can send the signed copy to [email protected]. " Excerpt from rstudio/httpuv package, which you had no reason to know existed.

Please let me know when you've sent the email. Thank you for your help!

Best, Barret

schloerke avatar Apr 16 '18 03:04 schloerke

Thanks. Will submit asap - need to check if individual or corporate one applies here.

eduardszoecs avatar Apr 17 '18 21:04 eduardszoecs

@schloerke Done!

eduardszoecs avatar Apr 24 '18 19:04 eduardszoecs

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

CLAassistant avatar Oct 02 '19 15:10 CLAassistant