[script] [researcher] [check-symbiosis] adding magical research scripts

[Valherun]

Thanks to Crannach the original creator of researcher.lic on the in-game repo Modified to add in all missing research options for normal and symbiotic research. Also added in guild specific research.

check-symbiosis.lic relies on research.lic and will make sure your symbiotic research is both active and the one you want.

Will require https://github.com/rpherbig/dr-scripts/pull/5511 to update common-arcana

[Valherun]

Will require https://github.com/rpherbig/dr-scripts/pull/5511 as mentioned in the comments there.

I swear I'll figure out PR's eventually

[KatoakDR]

@Valherun thansk for putting these together. Would you please update this PRs title to be "[script] [researcher] add magical research script from Lich repo". And then in the PR description mention what other PRs this one depends on, for example like https://github.com/rpherbig/dr-scripts/pull/5480

I like having the dependencies listed in the description because it's front and center and doesn't get lost in the comments for a heavily discussed PR.

Thanks!

[asechrest]

@KatoakDR Will we have a collision with a same-named script from the other repo? I seem to recall something like that with log.lic.

[KatoakDR]

@KatoakDR Will we have a collision with a same-named script from the other repo? I seem to recall something like that with log.lic.

Yes, the copy in this repo will overwrite what anyone has downloaded if they have the same name.

I don't think it should be an issue unless:

1. This version isn't backwards compatible with what's in Lich repo, or
2. The Lich repo version is actively maintained there but not here and the divergence will be hostile

[KatoakDR]

wait_for_script_to_complete is required as this script is meant to be used within t2.

@Valherun good catch, I hadn't thought about someone trying to run this script in t2 to block other actions

[rpherbig]

I don't know much about research, but the code looks fine to me other than the few comments. ✔️

[Valherun]

@KatoakDR don't know why it won't let me comment on your example for comment for switching to buff.

The buff script would be good to switch to here. However, GAF is the only spell that needs to be used. There is no real "set" that research would use, so the only spell that would ever be available would be GAF and then you'd likely have people doing similar to this.

waggle_set:
  researcher: 
    << : *gaf
  gaf:
    << : *gaf

Or maybe I'm the only one that setups my individual spells as waggles in addition to sets?

-- edit -- Was working on the edits here and realized that you do bring up a valid point when I was thinking about it. I could see a lower level cleric wanting to cast SAP to allow for slightly higher GAF casts for instance. (thus allowing slightly reduced research times)

[KatoakDR]

Or maybe I'm the only one that setups my individual spells as waggles in addition to sets?

I do individual spells too, but my waggles are named after the full spell name and not the abbrev because I can't remember the abbrevs, so this still gives people some flexibility in naming their waggles sets.

-- edit -- Was working on the edits here and realized that you do bring up a valid point when I was thinking about it. I could see a lower level cleric wanting to cast SAP to allow for slightly higher GAF casts for instance. (thus allowing slightly reduced research times)

Exactly! I should have clarified in my original comment that this enabled people to add more spells that may assist their researching.

Thanks

[Kiriawen]

@Valherun @MahtraDR

Valherun, is this PR something you still intend to pursue or is it good to close out?

[jandersson]

The original script has been deleted, the diff is just now introducing a whole new script. I will give this a viking funeral

[jandersson]