node-credstash
node-credstash copied to clipboard
mv aws-sdk to peer deps
Since the aws sdk keeps some internal private vars eg: when doing AWS.config.update the sdk shouldn't be embeded, it's best to have it as a peer dependency.
The issue I had is that setting AWS_DEFAULT_REGION would have no effect as it would set it within the sdk embeded in the credstash module, but not the parent module using it