rowanhill
Draft: Add missing property types
have to think about how to continue and if this makes sense and how
maybe you can look at my comments questions.
Of course I will split this PR in several smaller PRs, one by one.
Hello! Sorry for the super long delay. This turned into something much larger than I was expecting, and to be honest I don't have the time to dig into this to give the kind of response it needs.
Do you think there's a route to a much, much smaller change (e.g. just typing a few key public methods)? If not, I'm afraid I think we should abandon this approach...
Yeah, its always like this, if you start without phpstan its really hard to get started with it.
But wanted to test the waters first, before diving into it entirely.
Of course we can
- install phpstan
- build a phpstan-baseline.neon
- try to separate into different chunks and do much smaller PRS
but given the time it took to write a review comment and you saying:
and to be honest I don't have the time to dig into this to give the kind of response it needs.
I wouldn't pursue this either.