rouge icon indicating copy to clipboard operation
rouge copied to clipboard
verified publisher icon rouge-ruby

Add lexer for IEC 61131-3 Structured Text

Open tali opened this issue 1 year ago • 1 comments

The new lexer uses sets of keywords to quickly categorize names and uses regular expressions for other elements like numbers and punctuation.

Closes #2024

tali avatar Feb 21 '24 08:02 tali

This is still in draft, I'd still like to work on disambiguation and include better example code. I already created this PR to be able to obtain some feedback about the current state. Especially feedback from smalltalk experts would be helpful for disambiguation of *.st files. Ruby is not my native language, so please also have a closer look that I did everything right.

tali avatar Feb 21 '24 08:02 tali

(just rebased to current master)

tali avatar Mar 18 '24 15:03 tali

@tali I really like this addition! I guess this is no longer draft and ready for maintainer review?

bufferoverflow avatar Apr 10 '24 08:04 bufferoverflow

This code passes all my tests and is able to highlight our production code. From my side it is ready. @jneen, @gfx, what do you think? Can we merge it?

tali avatar Apr 15 '24 07:04 tali

Hi @tancnle, can you have a look please? I'd like to get this into the next release so that we can use it in our company GitLab.

tali avatar May 02 '24 07:05 tali

@dblessing could you maybe review this? Would be a great addition to GitLab!

bufferoverflow avatar May 11 '24 13:05 bufferoverflow

@tali @bufferoverflow I will have a look at it sometime today.

tancnle avatar May 12 '24 23:05 tancnle

Thanks, @tali. LGTM 🚀

tancnle avatar May 13 '24 11:05 tancnle