ros2
Call callbacks only if unread count > 0 (backport #634)
This is an automatic backport of pull request #634 done by Mergify.
Mergify commands and options
More conditions and actions can be found in the documentation.
You can also trigger Mergify actions by commenting on this pull request:
-
@Mergifyio refreshwill re-evaluate the rules -
@Mergifyio rebasewill rebase this PR on its base branch -
@Mergifyio updatewill merge the base branch into this PR -
@Mergifyio backport <destination>will backport this PR on<destination>branch
Additionally, on Mergify dashboard you can:
- look at your merge queues
- generate the Mergify configuration with the config editor.
Finally, you can contact us on https://mergify.com
![mergify[bot] avatar](https://avatars.githubusercontent.com/in/10562?v=4 "Published by a pub.dev verified publisher"){kind=small}
Windows fails on rviz_assimp_vendor pkg.
--- stderr: rviz_assimp_vendor
23:46:44 CMake Warning
23:46:44 The DOWNLOAD_EXTRACT_TIMESTAMP option was not given and policy CMP0135 is
23:46:44 not set. The policy's OLD behavior will be used. When using a URL
23:46:44 download, the timestamps of extracted files should preferably be that of
23:46:44 the time of extraction, otherwise code that depends on the extracted
23:46:44 contents might not be rebuilt if the URL changes. The OLD behavior
23:46:44 preserves the timestamps from the archive instead, but this is usually not
23:46:44 what you want. Update your project to the NEW behavior or specify the
23:46:44 DOWNLOAD_EXTRACT_TIMESTAMP option with a value of true to avoid this
23:46:44 robustness issue.
23:46:44 This warning is for project developers. Use -Wno-dev to suppress it.
23:46:44
23:46:44 ---
23:46:44 Failed <<< rviz_assimp_vendor [10min 28s, exited with code 1]
23:46:44 The DOWNLOAD_EXTRACT_TIMESTAMP option was not given and policy CMP0135 is
That's just a warning. The real problem is that it failed to download the data. Likely a temporary network situation, I've kicked it off again.
i guess we just missed.
@clalancette it's been almost a year. i will rebase this and run CI again to make sure nothing goes wrong.
Thanks @fujitatomoya.
The Linux-aarch64 build failed but for reasons beyond this PR I think.