rclcpp icon indicating copy to clipboard operation
rclcpp copied to clipboard

Fix SharedFuture from async_send_request never becomes valid

Open llapx opened this issue 3 years ago • 4 comments

Signed-off-by: Lei Liu [email protected]

llapx avatar Nov 07 '22 03:11 llapx

It seems Jenkins broken:

17:21:20 FATAL: command execution failed
17:26:12 java.nio.channels.ClosedChannelException
17:26:12 	at org.jenkinsci.remoting.protocol.impl.ChannelApplicationLayer.onReadClosed(ChannelApplicationLayer.java:209)
17:26:12 	at org.jenkinsci.remoting.protocol.ApplicationLayer.onRecvClosed(ApplicationLayer.java:221)
17:26:12 	at org.jenkinsci.remoting.protocol.ProtocolStack$Ptr.onRecvClosed(ProtocolStack.java:817)
17:26:12 	at org.jenkinsci.remoting.protocol.FilterLayer.onRecvClosed(FilterLayer.java:288)

Can anybody fix it?

llapx avatar Nov 07 '22 09:11 llapx

It seems Jenkins broken:

With those sorts of errors, Jenkins will automatically re-run it, and it did. The latest one is failing because test_time_source failed. That probably bears looking into.

clalancette avatar Nov 07 '22 12:11 clalancette

@iuhilnehc-ynos can you run CI for this?

fujitatomoya avatar Nov 14 '22 07:11 fujitatomoya

CI:

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Windows Build Status

iuhilnehc-ynos avatar Nov 14 '22 07:11 iuhilnehc-ynos

@iuhilnehc-ynos can you review this? i need another review before merge.

fujitatomoya avatar Dec 01 '22 16:12 fujitatomoya

@fujitatomoya Should this be backported?

MiguelCompany avatar Jan 03 '23 14:01 MiguelCompany

@Mergifyio backport to humble

fujitatomoya avatar Jan 03 '23 20:01 fujitatomoya

backport to humble

✅ Backports have been created

mergify[bot] avatar Jan 03 '23 20:01 mergify[bot]