rclcpp icon indicating copy to clipboard operation
rclcpp copied to clipboard
verified publisher icon ros2

Modifies timers API to select autostart state

Open Voldivh opened this issue 3 years ago • 1 comments

Signed-off-by: Voldivh [email protected]

This PR addresses the issue #1980. Basically it gives the timers API a variable that enables or disables the start of the timer at initialization. The variable autostart is defaulted to True in order to avoid any breaks in current use of the API. In order to start the timer if autostart = false you can simply call the method timer->reset(). This PR is dependant on modifications on this PR at the RCL package and should be merged after that one.

Voldivh avatar Aug 26 '22 13:08 Voldivh

Looks good to me. Full CI including your rcl PR

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Windows Build Status

alsora avatar Aug 31 '22 11:08 alsora

Pulls: ros2/rcl#1004, ros2/rclcpp#2005, ros2/system_tests#508, ros2/rclpy#999 Gist: https://gist.githubusercontent.com/emersonknapp/f9353e435d78a1ff796a38b74eaf0547/raw/2a9e6c7645332dcc2c4a6d0fb6f7b66e6b428bb7/ros2.repos BUILD args: --packages-above-and-dependencies rcl rcl_action rclcpp rclpy test_rclcpp TEST args: --packages-above rcl rcl_action rclcpp rclpy test_rclcpp ROS Distro: rolling Job: ci_launcher ci_launcher ran: https://ci.ros2.org/job/ci_launcher/12240

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Windows Build Status

emersonknapp avatar Jun 14 '23 20:06 emersonknapp

CI is green, see https://github.com/ros2/rcl/pull/1004#issuecomment-1593338990

fujitatomoya avatar Jun 15 '23 21:06 fujitatomoya