geometry2 icon indicating copy to clipboard operation
geometry2 copied to clipboard

Add Tf2 versions of lookupTransform, lookupVelocity, setTransform

Open kyle-basis opened this issue 1 year ago • 4 comments

This PR implements #726 - see there for initial discussion.

Some notes:

  • No response was given for naming, so I went with *Tf2.
  • I'm not totally pleased with lookupVelocity - tf2 doesn't have a dual vector type that I can find, and I didn't really want to implement a new Velocity for this PR. I'm happy to back that part of the change out - the function can be moved wholesale into tf2_ros when the time comes, instead, as it's not part of BufferCoreInterface.
  • I combined the two manual reimplementations of toMsg into one reimplementation - it really shows that the interface is wrong here in the first place - the helper methods that should be used would cause a depedency loop.
  • tf2::Transform doesn't have a child_frame_id - I think I did the correct thing, but it might be worth introducing somehow.
  • ~~I'm unable to actually run the tests - I get an error on colcon build~~
  • My version of colcon doesn't appear to have filter support, testing is a little hard. I think the solution here is to use an underlay, will experiment

kyle-basis avatar Nov 12 '24 07:11 kyle-basis

Only test fails are due to linting - do y'all have a script to fix this automatically?

kyle-basis avatar Nov 13 '24 07:11 kyle-basis

Only test fails are due to linting - do y'all have a script to fix this automatically?

I think you can run ament_uncrustify --reformat to fix it.

clalancette avatar Nov 13 '24 15:11 clalancette

Linting fixed - not sure why tf2_rospy is failing on jenkins, though

kyle-basis avatar Nov 13 '24 22:11 kyle-basis

@tfoote do you mind to take a look ?

@tfoote Friendly ping for review.

MichaelOrlov avatar Nov 21 '24 18:11 MichaelOrlov