roscpp_core

roscpp_core copied to clipboard

rostime: Added useful time and duration constants.

4

For `Time`, `WallTime` and `SteadyTime`, I added static constants `MIN`, `MAX`, `ZERO` and `UNINITIALIZED`. For `Duration` and `WallDuration`, I added static constants `MIN`, `MAX`, `ZERO`, `NANOSECOND`, `MICROSECOND`, `MILLISECOND`, `SECOND`, `MINUTE`,...

peci1

Hi, By reading through the code of the `rostime` package I found that `ros::Duration::sleep()` has an internal sleep in wall time with a length of `1,000,000 nanoseconds = 1 millisecond`....

YoshuaNava

ros::TimeBase: undefined behaviour for large doubles

2

`TimeBase::fromSec(double)` casts a `double` value to an `int64_t` value. If the double value is exceeds the `int64_t` range this is undefined behaviour ([for reference](https://en.cppreference.com/w/cpp/language/implicit_conversion#Floating.E2.80.93integral_conversions)).

cwecht

Fixed handling of infinite or >int64 doubles in Time and Duration constructors. Also added tests for Rate(double) constructor, verified Rate(inf) works and Rate(0) does not. Fixes #105.

peci1

inclusion of unecessary boost from ros console and ros time

1

Hi, We face long build times. In many compilation units `ros/console.h` is all that is is needed from ros. But that includes a lot of unecessary boost: ros/console.h includes ros/time...

thraen

ros serialization get wrong message size when compile on arm64 with gcc -O3

1

Example Project: https://github.com/AutoxingTech/simple_publisher_crash output message size ``` Publication::enqueueMessage 1 2427156042 Publication::enqueueMessage 2 2427156042 Publication::enqueueMessage 3 ```

randoms

Dear developers, we suspect that [ros::serialization::serializeServiceResponse](https://github.com/ros/roscpp_core/blob/noetic-devel/roscpp_serialization/include/ros/serialization.h#L823) had a bug to assign unused memory unsafely. when service response returned false (argument "ok" == false), [else statement](https://github.com/ros/roscpp_core/blob/noetic-devel/roscpp_serialization/include/ros/serialization.h#L838) assigned [(sizeof(message) + 1)](https://github.com/ros/roscpp_core/blob/noetic-devel/roscpp_serialization/include/ros/serialization.h#L841) bytes....

canalteks

LICENSE for v0.6.11

1

Hello, Can you please specify which BDS(full text), mentioned in https://github.com/ros/roscpp_core/blob/0.6.11/roscpp_core/package.xml applies on roscpp_core 0.6.11? There is no License file regarding the BSD that applies on roscpp_core 0.6.11. Thank you

oanastanca

ros::Rate::sleep is not working as expected when the rate is larger than the publish rate of /clock

2

We are currently adapting much of our software stack to work in simulation. There, `/clock` is published with a rate of 125Hz. In some parts of our software, we are...

timonegk

Compile errors with gcc-10 and -std=gnu++2a option

2

I'm using ROS Melodic on Ubuntu 18.04.5 with gcc-10.1. This test program compiles and runs fine with `-std=gnu++17` option, but fails to compile with `-std=gnu++2a`: ``` #include #include #include #include...

pauljurczak