ros
Add starting_up_state parameter to Updater
In the current implementation, when the Updater object is constructed, it sends off an "OK" signal. This could be problematic if we consider "Everything is running as expected" (definition of "OK" status as per REP107), that running is already initialized.
The default behavior doesn't change with this PR, so it wouldn't break anything. Also, in the python implementation, None can be passed to skip "Node starting up" status publishing altogether.
Hi! Can I get an update on this one?
If it wasn't merged because of this test case failing, can I get some help understanding the error? I'm sure a few minutes of someone who already understands these template-based tests can save me hours of trial and error. After that I can also rebase to fix the conflict.
Hi @redvinaa. Could we please have a quick discussion about this? I am not sure if it is worth the extra overhead. Yes,
"Everything is running as expected" (definition of "OK" status as per REP107)
On the other hand, I also would not like my system starting in an error state. Your issue could also be solved by additional state, such as proposed in https://github.com/ros2/common_interfaces/issues/268. What is your opinion about that?
Hi! Sorry for the long delay. It's possible that it would make sense to add new states, but that's a huge change and it appears to be moving very slowly. This PR on the other hand is not breaking, and I think is still useful until the new states get added.