deprecation warning for node.js 12

[jarkenau]

Description

When using the action in a workflow, GitHub adds a notice that Node.js 12 is deprecated and will be removed soon. This also applies for the ros-tooling/action-ros-ci.

To Reproduce

Use ros-tooling/[email protected]

Could we just upgrade the version to Node.js 16 ? :thinking:

[christophebedard]

Thanks for bringing this up! I'm not sure what upgrading to a more recent version entails other than modifying this line: https://github.com/ros-tooling/setup-ros/blob/16c95b566a82852112e58201d9cf69044c12b29b/action.yml#L41

but I can look into it some time in the coming weeks.

[jarkenau]

Just wanted to let you know, I updated to node16 in a fork and used it for another repository. The deprecation warning is gone and everything works as expected, but I just use some basic features of this action, so not sure about edge cases.

Also, the actions/typescript-action this action is based on updated to node16 a while ago: https://github.com/actions/typescript-action/commit/87fd0349ba2dff5d5598104cec63562cdec81fa5

[christophebedard]

Great, thanks for the info! I'll do that and update the version in the CI configs as well.

[christophebedard]

I've created PRs for setup-ros and action-ros-ci: https://github.com/ros-tooling/setup-ros/pull/521 and https://github.com/ros-tooling/action-ros-ci/pull/778. A lot of the local CI jobs are failing due to an issue with permissions. Something like this: https://github.com/cypress-io/github-action/issues/446. I'll have to look into it.