laser_assembler icon indicating copy to clipboard operation
laser_assembler copied to clipboard

added native sensor_msgs::PointCloud2 support without conversion

Open spuetz opened this issue 10 years ago • 4 comments

Since the conversion from PointCloud2 to PointCloud and back for assembling the clouds is bad, I added a native sensor_msgs::PointCloud2 support without conversion. I also added an organized mode, to assemble PointClouds2 to an organized PointCloud2.

spuetz avatar Jul 19 '15 16:07 spuetz

overall very useful, thank you. It will probably take use a few days to get through the code. I believe some code should be part of the base class (as private lightweight functions). E.g., all that code is duplicated for PointCloud and PointCloud2:

if (field->offset != this->scan_hist_[start_index].fields[chan_ind].offset){

Please have only one function for those (like a function that return analyses two different PointFields)

vrabaud avatar Jul 19 '15 21:07 vrabaud

@spuetz , any comments on that ?

vrabaud avatar Aug 02 '15 20:08 vrabaud

@vrabaud, I added the method hasEqualScanHeader to check the headers. as recommended by you. Additionally, I fixed the down-sampling for the organized mode.

spuetz avatar Aug 24 '15 14:08 spuetz

@vrabaud, would be nice, if we can complete this pull request and merge it. thx

spuetz avatar Sep 24 '15 11:09 spuetz