laser_assembler icon indicating copy to clipboard operation
laser_assembler copied to clipboard

Ros2 crystal

Open vandanamandlik opened this issue 7 years ago • 1 comments

  • ros2-crystal branch is created from ros2-devel.

  • Then I did following two changes for crystal

    Replaced manual conversion of nanoseconds to seconds with function seconds() in message_filter.hpp

      rclcpp::Time class of Bouncy was not having seconds() function but now its available in crystal so used it here.
    
      vandanamandlik@5dbb984
    

    Removed manually clone and build steps of message_filters and launch package from readme because now it available in crystal, Changed raw pointer to shared_pointer.

      vandanamandlik@4995443
    
      message filter package was not there in bouncy, So in order to build laser assembler
      I was cloning and buiding it from intel message filter repository.
      Now its available in crystal release so that step is skipped in crystal.
    
      launch package was not fully ported in bouncy so there I was using master branch of launch packge repository. But now its available in crystal so this step is also skipped in crystal.
    
      Changed raw pointer to shared pointer in base_assembler.hpp
      subscribe method of intel's message_filters package was accepting raw node pointer only,
      virtual void subscribe(rclcpp::Node * node, const std::string& topic, const rmw_qos_profile_t qos = rmw_qos_profile_default) = 0;
      In crystal subscribe() method can accept shared_pointer so changed raw pointer to shared_pointer in crystal.
    

Could you please review it and give your feedback ?

vandanamandlik avatar Jan 07 '19 14:01 vandanamandlik

@vandanamandlik I think most of the comments on your other PR will transfer over to this one. Once we get that PR merged, I'll do a quick pass over this one.

jonbinney avatar Jan 14 '19 02:01 jonbinney