ros-perception
Ros2 devel
Initial port for Laser assembler I have ported all files from this package to ROS2 as per ROS2 migration guide. But I could test only laser_scan_assembler.cpp, base_assembler.h, dummy_scan_producer.cpp and test_assembler.cpp files, Because non_zero_cloud_test from test_assembler uses only above files.
@tfoote this PR will change the license on the laser_assembler code to Apache 2 for the ROS2 branch. That sounds like the right license to use, and I'm happy with the change, but it is technically a change from the previous BSD license. I assume this has been thought about for other repositories - are there any issues with updating the license of a package that has been around for a while?
@jonbinney is right that ported code should retain the original license. Only the copyright holder can change the license on the existing code. New code can be added under a new license, but for consistency we recommend that for packages being ported new code be contributed under the original license.
If there's large well separated new functionality that can be licensed separately that's fine, but in general consistency is more valuable than moving to our new preferred Apache 2.0 license.
@jonbinney I agree with you. I will retain the original license. But it will result into failure of lint copyright test case (https://github.com/ament/ament_lint/blob/master/ament_cmake_copyright/doc/index.rst). Would it be ok ?
@jonbinney, I have tested all the changes on ROS2 bouncy. I have also added ros2_migration_readme file which contain build and test related steps. Could you please review it and give your feedback?
@tfoote can you comment on the question about the linter that @vandanamandlik mentions above? Is it expected that ported packages with different licenses will be flagged by the linter?
Hey, I just wanted to check and see is there anything holding back this PR?
