calibration

calibration copied to clipboard

compile fixes for calibration stack with fixes for tests to work in focal/noetic. Passes prerelease tests: generate_prerelease_script.py https://raw.githubusercontent.com/ros-infrastructure/ros_buildfarm_config/production/index.yaml noetic default ubuntu focal amd64 --custom-repo calibration__custom-3:git:https://github.com/PR2-prime/calibration.git:noetic-devel --level 0 --output-dir ./

davefeilseifer

The `image_cb_detector` and `laser_cb_detector` packages try to find the Boost signals library. This library is not used by these packages and has been deprecated since Boost 1.54 and was removed...

lopsided98

Being added to a metapackage increases community visibility way better.

130s

`eval` is used, which is unsafe

5

In the following places: - https://github.com/ros-perception/calibration/blob/20d3bbf5ec78027831f75cf90c2aac737a00e978/calibration_estimation/src/calibration_estimation/single_transform.py#L48 - https://github.com/ros-perception/calibration/blob/20d3bbf5ec78027831f75cf90c2aac737a00e978/calibration_estimation/src/calibration_estimation/joint_chain.py#L52 - https://github.com/ros-perception/calibration/blob/20d3bbf5ec78027831f75cf90c2aac737a00e978/calibration_estimation/src/calibration_estimation/urdf_params.py#L144 What type of input is this trying to parse?

eric-wieser

kinect_pipeline should be updated to new-style topic names

4

Still uses the old openni_camera names, doesn't account for depth_registered stuff.

mikeferguson

Joint commands should be action-based. Do this for hydro as it is API-breaking under groovy.

mikeferguson

The python3 bugs were plain broken in current noetic-devel. The rest are noetic-compatible changes to address warnings/errors when building on newer systems.

v4hn