ros2_controllers icon indicating copy to clipboard operation
ros2_controllers copied to clipboard

Generate parameter library for diff drive

Open pac48 opened this issue 3 years ago • 3 comments

This is an example PR of converting the parameter usage in differential drive controller to use https://github.com/PickNikRobotics/generate_parameter_library

pac48 avatar Jul 21 '22 23:07 pac48

This pull request is in conflict. Could you fix it @pac48?

mergify[bot] avatar Jul 23 '22 17:07 mergify[bot]

This pull request is in conflict. Could you fix it @pac48?

mergify[bot] avatar Jul 30 '22 07:07 mergify[bot]

This pull request is in conflict. Could you fix it @pac48?

mergify[bot] avatar Sep 28 '22 09:09 mergify[bot]

Codecov Report

Merging #386 (a6ad3a7) into master (e7f9962) will decrease coverage by 3.25%. The diff coverage is 26.93%.

@@            Coverage Diff             @@
##           master     #386      +/-   ##
==========================================
- Coverage   35.78%   32.53%   -3.26%     
==========================================
  Files         189        7     -182     
  Lines       17570      664   -16906     
  Branches    11592      356   -11236     
==========================================
- Hits         6287      216    -6071     
+ Misses        994      156     -838     
+ Partials    10289      292    -9997     
Flag Coverage Δ
unittests 32.53% <26.93%> (-3.26%) :arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ontroller/test/test_load_diff_drive_controller.cpp 12.50% <0.00%> (ø)
diff_drive_controller/src/odometry.cpp 42.16% <11.11%> (ø)
...ive_controller/test/test_diff_drive_controller.cpp 17.62% <12.08%> (ø)
diff_drive_controller/src/speed_limiter.cpp 46.55% <13.33%> (ø)
...troller/include/diff_drive_controller/odometry.hpp 20.00% <20.00%> (ø)
...iff_drive_controller/src/diff_drive_controller.cpp 39.36% <35.67%> (ø)
...de/diff_drive_controller/diff_drive_controller.hpp 100.00% <100.00%> (ø)
...mand_controller/src/forward_command_controller.cpp
...ller/test/test_load_forward_command_controller.cpp
...ntroller/test/test_load_joint_state_controller.cpp
... and 191 more

codecov-commenter avatar Dec 03 '22 11:12 codecov-commenter