Rootul P

Results 532 comments of Rootul P

I'm not actively working on it. Defer to @Wondertan if we still want to fix this. I assumed it's still happening in celestia-node but I just tried `go test ./......

Perhaps useful for assignee, you can generate code coverage via: ```shell cd service/header go test . --coverprofile=coverage.out go tool cover -html=coverage.out ``` service/header/store.go is at 79.9% test coverage. The uncovered...

@HoytRen it looks like it was moved to https://github.com/celestiaorg/celestia-node/tree/main/header For example: https://github.com/celestiaorg/celestia-node/blob/main/header/store/store.go

It looks like `ExtendedHeader` is defined [here](https://github.com/celestiaorg/celestia-node/blob/main/header/header.go#L30-L38) but I couldn't find a `ExtendedBlock` or `Block` definition in celestia-node. Is `ExtendedBlock` still relevant? @renaynay is there remaining work on this issue?...

A candidate sub-task for this issue is to delete the duplicate definitions of `randomValidNamespace`: 1. https://github.com/celestiaorg/celestia-app/blob/27632ddc804fbf7655ef5ba941eb4f346c539be9/testutil/payment/testutil.go#L134 2. https://github.com/celestiaorg/celestia-app/blob/e18de882c3de4ee92e4632af21d4007c1b642adb/app/test_util.go#L178 3. https://github.com/celestiaorg/celestia-app/blob/8f4fd811b19b8539bfd9e77e83f23518ec702c88/app/test/block_size_test.go#L299 4. https://github.com/celestiaorg/celestia-app/blob/906fdf74f871f13d3fe0c632dfda95db494521ee/pkg/prove/proof_test.go#L290 5. https://github.com/celestiaorg/celestia-app/blob/07b5bb4a6dd905166c33b3434895cd292501f100/testutil/utils.go#L15 The last function definition is the...

Spun out https://github.com/celestiaorg/celestia-app/issues/836 in-case @evan-forbes has other ideas for what this issue should include.

This is blocked on https://github.com/celestiaorg/celestia-app/pull/856

hmm I can't merge `main` into this branch I wanted to merge `main` to pick up the new CODEOWNERS file

@musalbas apologies for delayed response. @adlerjohn and I triaged issues in https://github.com/celestiaorg/celestia-app/issues/650 today. I think that the `specs-staging` branch is already a more accurate representation of the specs than https://celestiaorg.github.io/celestia-specs/latest/index.html...

Related: https://github.com/celestiaorg/celestia-app/issues/711