trellis-cli icon indicating copy to clipboard operation
trellis-cli copied to clipboard

Add compatibility for log-commands when using other DEV VM managers like Lima

Open E-VANCE opened this issue 1 year ago • 1 comments

This PR should add compatibility for running log-commands like trellis logs --error development when using other DEV VM managers then Vagrant like Lima.

See #511.

Also includes an added test case for ensuring the tailCmd method correctly generates command strings based on different flag combinations.

Couldn't get around to test this one yet as I am unsure how to use brew to install the forked trellis-cli...?

Disclaimer: I am not a go-to-guy and had a little help from AI and there may be a few too many comments included 💡

E-VANCE avatar Mar 12 '25 13:03 E-VANCE

Thanks for the proposed improvement.

Couldn't get around to test this one yet as I am unsure how to use brew to install the forked trellis-cli...?

When you run go build locally, I just export the PATH like this:

export PATH=$PATH:/your/path/to/trellis-cli

Then run trellis-cli from anywhere to run the local binary

My main feedback for this PR is that I'd like to have the logic unified. Right now there's two completely separate paths. For example the goaccess check is duplicated in two places. Ideally we could figure out the tail command separately.

swalkinshaw avatar Mar 25 '25 02:03 swalkinshaw