Huamin Chen

Results 225 comments of Huamin Chen

> Maybe 3+ approvals is too much > > I would suggest, the PR must have a `lgmt` label and 1 approval Both the reviewers and maintainers can approve but...

@sallyom has some ideas

FYI, i just created teams. CI can tag the teams to assign/review/merge issues and PR

> We can have this information in the same metric, as it will be easier to aggregate and manipulate the information in Prometheus But instead of using the pod name...

@marceloamaral Let's keep the conformance and usability goals in sync. The new metrics are good for query and dashboarding. The `pod_cpu_cpu_time_us`, `node_package_energy_millijoule`, and `node_energy_stat` are used by the model server...

> Also, most of the metrics from the cgroup are already exported to prometheus, so we probably don't need to export them and the model server will get these metrics...