FreeBSD missing include

[mkrzewic]

Some tests (some root-dataframe*) fail being unable to find vdt/vdtMath.h which is installed in /usr/local/include. making this explicit solves it, but maybe it should either be conditional (FreeBSD only) or there is a better place to make sure the interpreter looks in /usr/local/include?

[phsft-bot]

Can one of the admins verify this patch?

[sonatype-lift[bot]]

Sonatype Lift is retiring

Sonatype Lift will be retiring on Sep 12, 2023, with its analysis stopping on Aug 12, 2023. We understand that this news may come as a disappointment, and Sonatype is committed to helping you transition off it seamlessly. If you’d like to retain your data, please export your issues from the web console. We are extremely grateful and thank you for your support over the years.

📖 Read about the impacts and timeline

[pcanal]

vdt/vdtMath.h which is installed in /usr/local/include.

This seems specific to system you use and on other system it will be installed somewhere else.

Some tests (some root-dataframe*) fail being unable to find vdt/vdtMath.h

This seems to be a real error that a user using this same/similar installation of ROOT will also encounter. i.e. This PR only hides the problem.

[mkrzewic]

This seems to be a real error that a user using this same/similar installation of ROOT will also encounter. i.e. This PR only hides the problem.

I guess this PR illustrates the problem since there is no issue tracker in this repository... hence also my questions.

/usr/local/include is a reasonably standard place to be looking for headers, so maybe this should be buried deeper - my question is where is the appropriate place? in all other cases root has no problem finding headers in /usr/local/include...

[pcanal]

in all other cases root has no problem finding headers in /usr/local/include...

Humm ... So let figure out what is "special" about this case. What tests are actually failing and what is the output?

[mkrzewic]

e.g. roottest-root-dataframe-writeFcc

1576: -- BEGIN TEST OUTPUT --
1576: 
1576: Processing /usr/home/mkrzewic/src/roottest/root/dataframe/writeFcc.C+...
1576: Info in <TUnixSystem::ACLiC>: creating shared library /home/mkrzewic/build/root/roottest/root/dataframe/writeFcc_C.so
1576: In file included from input_line_9:6:
1576: In file included from /usr/home/mkrzewic/src/roottest/root/dataframe/writeFcc.C:1:
1576: In file included from /usr/local/include/root/ROOT/RDataFrame.hxx:21:
1576: In file included from /usr/local/include/root/ROOT/RDF/RInterface.hxx:15:
1576: In file included from /usr/local/include/root/ROOT/RDF/ActionHelpers.hxx:24:
1576: /usr/local/include/root/ROOT/RVec.hxx:54:10: fatal error: 'vdt/vdtMath.h' file not found
1576: #include <vdt/vdtMath.h>
1576:          ^~~~~~~~~~~~~~~
1576: Error in <ACLiC>: Executing '/usr/home/mkrzewic/build/root/bin/rootcling -v0 "--lib-list-prefix=/home/mkrzewic/build/root/roottest/root/dataframe/writeFcc_C_ACLiC_map"-f "/home/mkrzewic/build/root/roottest/root/dataframe/writeFcc_C_ACLiC_dict.cxx" -I/usr/local/include/root -I/home/mkrzewic/build/root/roottest/root/dataframe -I"/usr/home/mkrzewic/build/root/etc/" -I"/usr/home/mkrzewic/build/root/etc//cling" -I"/usr/home/mkrzewic/build/root/etc//cling/plugins/include" -I"/usr/home/mkrzewic/build/root/include/" -I"/usr/home/mkrzewic/build/root/include" -I"/home/mkrzewic/build/root/roottest/root/dataframe" -D__ACLIC__  "/usr/home/mkrzewic/src/roottest/root/dataframe/writeFcc.C" "/home/mkrzewic/build/root/roottest/root/dataframe/writeFcc_C_ACLiC_linkdef.h"' failed!
1576: 
1576: -- END TEST OUTPUT --