root icon indicating copy to clipboard operation
root copied to clipboard

[cling] Make parts of the cling codebase similar to upstream `clang-repl`

Open devajithvs opened this issue 1 year ago • 5 comments

This Pull request:

Makes non-breaking changes to the existing code to make cling similar to upstream clang-repl. The idea is to make more changes in a similar fashion and completely swap out certain functions when they are similar enough.

Changes or fixes:

Checklist:

  • [ ] tested changes locally
  • [ ] updated the docs (if necessary)

This PR fixes #

devajithvs avatar Apr 29 '24 08:04 devajithvs

@smuzaffar, we will probably start moving towards more upstream llvm parts in Cling. These PRs need to be tested on cmssw because of relocation and pcms. Can you test this PR?

vgvassilev avatar Apr 29 '24 10:04 vgvassilev

Test Results

    10 files      10 suites   2d 5h 48m 40s :stopwatch:  2 631 tests  2 631 :white_check_mark: 0 :zzz: 0 :x: 24 807 runs  24 807 :white_check_mark: 0 :zzz: 0 :x:

Results for commit 244d744e.

github-actions[bot] avatar Apr 29 '24 10:04 github-actions[bot]

@smuzaffar, we will probably start moving towards more upstream llvm parts in Cling. These PRs need to be tested on cmssw because of relocation and pcms. Can you test this PR?

CMSSW tests started via cms-sw/root#206

smuzaffar avatar Apr 29 '24 12:04 smuzaffar

@vgvassilev , cmssw tests looks good. A unit test failure is not related to this PR.

smuzaffar avatar Apr 29 '24 21:04 smuzaffar

@smuzaffar, thank you!

ROOT CI / mac14 ARM64 LLVM_ENABLE_ASSERTIONS=On seems to be broken at cmake configuration and I do not see how this could be caused by this PR. Let's move forward here.

vgvassilev avatar May 01 '24 13:05 vgvassilev