github-light.vim icon indicating copy to clipboard operation
github-light.vim copied to clipboard

support Treesitter highlight groups

Open ilAYAli opened this issue 5 years ago • 3 comments

Support for Treesitter highlight groups would be much appreciated:

TSError
TSPunctDelimiter
TSPunctBracket
TSPunctSpecial
TSConstant
TSConstBuiltin
TSConstMacro
TSStringRegex
TSString
TSStringEscape
TSCharacter
TSNumber
TSBoolean
TSFloat
TSAnnotation
TSAttribute
TSNamespace
TSFuncBuiltin
TSFunction
TSFuncMacro
TSParameter
TSParameterReference
TSMethod
TSField
TSProperty
TSConstructor
TSConditional
TSRepeat
TSLabel
TSKeyword
TSKeywordFunction
TSKeywordOperator
TSOperator
TSException
TSType
TSTypeBuiltin
TSStructure
TSInclude
TSVariable
TSVariableBuiltin
TSText
TSStrong
TSEmphasis
TSUnderline
TSTitle
TSLiteral
TSURI
TSTag
TSTagDelimiter
TSNone
TSQueryLinterError

ilAYAli avatar Feb 03 '21 09:02 ilAYAli

Doesn't treesitter fallbacks on standard groups?

Also note that I'm not using this colorscheme at the moment so I'm unlikely to implement this. I might do it if I come back to this colorscheme but for now I'm with the dark side. I'd accept a PR though.

romgrk avatar Feb 11 '21 14:02 romgrk

@romgrk yes, treesitter has fallback to standard groups, but additional highlight groups makes for a much better experience. I am usually on the darker side too, but this is my preferred theme; outside, on a bright summer day, with a beer in my hand, and laptop on my ....lap. Sadly, that is a few months into the future.

ilAYAli avatar Feb 11 '21 16:02 ilAYAli

I totally understand it, it's also my favourite light theme.

I will put it in my todo list and will try to get it done by this summer. I'll probably be updating my dark theme at the same time, both themes are forks of each other so adding the groups to one makes it trivial to add them to the other.

romgrk avatar Feb 12 '21 09:02 romgrk