tools icon indicating copy to clipboard operation
tools copied to clipboard

fix(rome_js_formatter): Single-line comment below a JSX prop triggers…

Open denbezrukov opened this issue 3 years ago • 1 comments

Summary

Fix https://github.com/rome/tools/issues/3598

Try to make the same IR as Prettier has based on:

  • https://github.com/prettier/prettier/blob/5e0b88329e54df515d84dc33d6fc38c2cb176678/src/language-js/print/jsx.js#L567-L601

  • https://github.com/prettier/prettier/blob/5e0b88329e54df515d84dc33d6fc38c2cb176678/src/language-js/print/jsx.js#L643-L665

There is no line_suffix_boundary

Test Plan

cargo test -p rome_js_formatter

denbezrukov avatar Nov 10 '22 09:11 denbezrukov

Deploy Preview for docs-rometools canceled.

Name Link
Latest commit 295ff312ba571fd008306574910f293b2d3c4ecf
Latest deploy log https://app.netlify.com/sites/docs-rometools/deploys/6371ec6fcefa8d000ae1778c

netlify[bot] avatar Nov 10 '22 09:11 netlify[bot]