rombert
Close review request and commit in one operation
Improvement: it should be possible to close a review request and commit in one operation.
One should also have the possibility to link review request and commit:
- by automatically enter information about the review in the commit comment (which information to include and format to be defined by a template provided by user):
- review id
- reviewer
- url to review
- by adding commit identifier as a comment in review
Sounds like an interesting improvement. Is this something that you see done within Eclipse, collaborating with other plugins, e.g. EGit, Subclipse?
Yes. Not quite sure at the moment how it would be best to organize as far as plugin dependencies are concerned. The toughest part of it all might be to link a change set to a review request.
Actually I think that the Mylyn team apis allow for this. I am not sure though if I can hook into the commit process of a source control plugin and automatically perform my action as well. Might be really nice though.
I think this is at least partly doable for our new Subclipse integration. Are you using Subclipse by any chance?
I see. I do not use CVS at all right now so I'm not in a position to develop it. I'm tagging it for CVS then but removing the milestone.
If your company uses CSV and Eclipse, perhaps you are interested in contributing the CVS integration? Adding a SCM extension is pretty easy.
We're now using post-review to create the review requests but are not happy with the solution, so a CVS integration would be nice. I see you just added it for Subclipse, I'll have to study that when time permits.
Nothing new concerning this improvement? Would be quite powerful to be able to automatically commit files in the same time than closing the review. Information from the review could also automatically be integrated in the commit comment.
