search icon indicating copy to clipboard operation
search copied to clipboard

[Feature] Elasticsearch 7

Open jkabat opened this issue 2 years ago • 4 comments

Any plan to support ruflin/Elastica:^7 any time soon?

jkabat avatar Apr 15 '23 15:04 jkabat

@sstok maybe I could help with this one - do you have any sidenotes which could speed up the process?

jkabat avatar Apr 21 '23 13:04 jkabat

I haven't used Elasticsearch myself, I know @dkarlovi did most of the work on this integration. Maybe he can provide some help.

sstok avatar Apr 26 '23 07:04 sstok

@jkabat please feel free to contribute any fixes and features, I haven't really used this library actively since we last spoke in #268. :+1: Thanks!

dkarlovi avatar Apr 26 '23 08:04 dkarlovi

@sstok @dkarlovi my preliminary tests show that by allowing ruflin/Elastica:^7.0 everything works as supposed to.

You are even doing tests using that package and elasticasearch v7: https://github.com/rollerworks/search/blob/v2.0.0-BETA2/composer.json#L53 https://github.com/rollerworks/search/blob/v2.0.0-BETA2/.github/workflows/ci.yaml#L48

It is just not allowed for the single package: https://github.com/rollerworks/search-elasticsearch/blob/v2.0.0-BETA2/composer.json#L26

Right now Im using my fork and testing my implementation against v7. Ill provide feedback and fixes if necessary. Thanks again for the hard work on this library.

jkabat avatar Apr 27 '23 20:04 jkabat