`rojo build --watch` not registering globIgnorePaths or needs debounce

[sasial-dev]

I'm using rojo build --watch and there's no debug way (even when I use --verbose!) to tell me what files have been changed. Either changes need to be debounced slightly to prevent overloading of output as shown below, or it is an issue with my .project.json file not registering the globIgnorePaths properly.

My project.json file:

{
	"name": "roblox-ts-plugin",
	"globIgnorePaths": [
		"**/package.json",
		"**/tsconfig.json",
		"out/tsconfig.tsbuildinfo"
	],
	"tree": {
		"$path": "out",
		"include": {
			"$path": "include",
			"node_modules": {
				"$path": "node_modules/@rbxts"
			}
		}
	}
}

https://user-images.githubusercontent.com/44125644/178163297-02534b71-601b-4bbc-ab8d-5c77098cfde5.mp4

[LPGhatguy]

I'm not sure what this video is showing. It looks like rojo build is triggering multiple times for a batch of changes.

I think that Rojo's file watching needs some work put into it. We do have a debounce set up, but it's possible that we need to consume all pending filesystem events at once and do a secondary debounce.

[sasial-dev]

Yeah, it's:

1. is triggering multiple times for a batch of changes
2. doesn't seem to be actually working some of the time, needing that secondary debounce

[Boegie19]

I think I found the underlying issue

changed does not respect globIgnorePaths aka if you update something what is in globIgnorePaths it will still see the change and fire it it will only say in the patch_set that noting changed

I see 3 options for how to fix this:

1 rewrite changed so that it does not react to globIgnorePaths files (will be the longest way to fix it but probably also the neatest still is it worth the time)

2 check patch_set before push_messages to the message_queue (This could cause problems if other parts of rojo need to know of the changes even if it is not in the ignore path but will be a quick fix)

3 just make build ignore all messages where the patch_set is empty

Fixes 2 and 3 I can do myself if you choose option 1 then I think someone who knows the rojo project better and has more experience with rust needs to do it.

So my question now becomes what fix should we apply here?

[Boegie19]

Only thing that still needs to be done is

I'm not sure what this video is showing. It looks like rojo build is triggering multiple times for a batch of changes.

I think that Rojo's file watching needs some work put into it. We do have a debounce set up, but it's possible that we need to consume all pending filesystem events at once and do a secondary debounce.