Roji Philip
Roji Philip
Thanks for all your proposals. @Krishna2323 [proposal](https://github.com/Expensify/App/issues/51096#issuecomment-2452926581) LGTM as using form `shouldSaveDraft` seems better than managing another custom entry in Onyx to implement this feature. However, I am not sure...
@anmurali I think we can take this out of hold now since the dependent PRs are all merged
> Could you take a look at [my proposal](https://github.com/Expensify/App/issues/51096#issuecomment-2422915303)? My proposal is the second one listed, and it suggests using a different key to save the draft message, which aligns...
The test video [here](https://github.com/Expensify/App/issues/51096#issuecomment-2458171131) by @Krishna2323 brings another interesting use case. I have added test steps 20 to 23 to address this case. @dannymcclain Can you please confirm if the...
> I don't think we should show the default welcome message after inviting users with an empty message. In my opinion, we should show an empty input to keep it...
@bernhardoj [proposal](https://github.com/Expensify/App/issues/48710#issuecomment-2335894152) LGTM as updation of workspace name and avatar requires `policy` in `getIcons` and `getReportName`. Regarding the optional suggestion, let us not change the existing order of report `policyAvatar`...
* [x] [@rojiphil] The PR that introduced the bug has been identified. Link to the PR: [Offending PR](https://github.com/Expensify/App/pull/44970) * [x] [@rojiphil] The offending PR has been commented on, pointing out...
> can you propose regression testing if needed? Thank you! @OfstadC I have completed the BZ checklist which includes the regression test. Thanks.
> It looks like you haven't accepted the offer yet. Could you please accept [this offer ](https://www.upwork.com/nx/wm/offer/104007817)so I can issue payment in Upwork? 😃 @OfstadC Accepted Offer. Thanks.