peridot icon indicating copy to clipboard operation
peridot copied to clipboard

small changes for setup scripts

Open JasonYangShadow opened this issue 2 years ago • 5 comments

I found that small changes were required for the setup script during my setup.

JasonYangShadow avatar Feb 29 '24 08:02 JasonYangShadow

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: JasonYangShadow Once this PR has been reviewed and has the lgtm label, please assign neilhanlon for approval by writing /assign @neilhanlon in a comment. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

resf-prow[bot] avatar Feb 29 '24 08:02 resf-prow[bot]

Hi @JasonYangShadow. Thanks for your PR.

I'm waiting for a rocky-linux member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

resf-prow[bot] avatar Feb 29 '24 08:02 resf-prow[bot]

/ok-to-test

NeilHanlon avatar Mar 06 '24 05:03 NeilHanlon

Thank you for the PR @JasonYangShadow !

NeilHanlon avatar Mar 06 '24 05:03 NeilHanlon

Thank you for the PR @JasonYangShadow !

still having issue on deploying the peridot locally, if you have pushed up your patches/fixes for peridot dev env, please feel free to DM me and I will test and update relative docs for peridot. Thanks! 👍🏽

JasonYangShadow avatar Mar 06 '24 06:03 JasonYangShadow