Shouldn't this be set to 7200 to equal 24 hrs.

Open htimsk opened this issue 4 years ago • 1 comments

https://github.com/rocket-pool/rocketpool/blob/a81c41c3b9cf46de76cfd58e34ac72b0dfdbb037/contracts/contract/dao/protocol/settings/RocketDAOProtocolSettingsMinipool.sol#L24

If I'm understanding is the number 5760 a unit of block time. If so I recommend that this be changed to 7200 anticipating 12-second blocks post the quick merge. This would be prior to the quick merge that the dissolve time is a little longer (~26 hrs).

Apr 19 '21 03:04 htimsk

I believe this is ETH 1 blocks, although it may need updating according to https://ycharts.com/indicators/ethereum_blocks_per_day

Apr 24 '21 20:04 kidkal