Roch Devost

Results 372 comments of Roch Devost

Is this something you are able to reproduce with a snippet you could share? For example, if you can extract one of the problematic endpoints and remove your business logic...

This file is the source for this page: https://datadoghq.dev/dd-trace-js/ Unfortunately it can't be used directly from GitHub but all the links should work in the generated page.

@zelongc Do you have something specific in mind? Where do you think would make the most sense for the examples? Should we put them in the API doc, on the...

This is a known issue that is unfortunately a limitation of Node support for promises. Without going into too much details, it binds the context of `async_hooks` to the context...

The test case focuses on a very specific usage of the library and doesn't address other patterns (for example `async/await`, `Promise.all()`, nested or chained `then()`, etc). This makes it incomplete...

I just realized that the tests in #1682 don't verify if the context was propagated properly, so I should probably provide more background as to why this doesn't work. Basically,...

@uptownhr Not a sample per se, but from a quick look at the library it looks like `handleMessage` is very similar to kafkajs [eachMessage](https://github.com/DataDog/dd-trace-js/blob/63dca718ba6a52de8588830ceade7e29e558bb09/packages/datadog-plugin-kafkajs/src/index.js#L62-L80) so the code would probably be...

@leoncider Been wanting to work on this for a while but haven't had the time. We're going to try to land support for aws-sdk v3 soon, I'll try to see...

@ixalon If you are not using async/await it should be possible to instrument the call manually. If you are using async/await you might not be able to bind the asynchronous...

Thanks for the PR, I'll take a look! Regarding the above about upstreaming, I'd definitely recommend it whenever possible to avoid forks with different capabilities. I think all the features...