Rob Wise

Results 36 comments of Rob Wise

@haroldtreen This is awesome. Maybe we can try `babel-plugin-lodash` for the lodash problem?: https://github.com/lodash/babel-plugin-lodash

@haroldtreen I read your blog post, was super cool! I think all of these ideas sound cool: - import-lazy: I didn't expect would get us any additional perf over our...

I'm going to close this for now because I think our objectives have been accomplished and activation time has been significantly reduced.

@haroldtreen thanks for reporting the regression! I wonder what the proper fix should be? It might be the case that Atom supports this stuff without a polyfill, but I'd have...

> I think babel will always be needed so flow types get stripped. Oh, duh! Good point! > I noticed that electron supports a lot of the features that were...

Oh my gosh, I wish there was some way to lock this down in some kind of automated performance test or something, but I don't think there's an easy way...

Okay I guess that means I can just go into those new modules and explicitly require or avoid using all of lodash/fp

> Are you open to a PR replacing all require('lodash/fp') with specific requires? Yes, but just for the files that are requested at activation time, what haroldteen refers to as...

That's definitely a possibility, but I'm worried that may actually have the opposite effect. Right now, Atom is lazy-loading most of our codebase so we're avoiding a lot of code...