robusta icon indicating copy to clipboard operation
robusta copied to clipboard

`Investigate` button should take user to the alert instead of the App detail page

Open itisallgood opened this issue 8 months ago • 1 comments

Summary by CodeRabbit

  • New Features

    • Investigation URIs for non-job resources now include the finding ID as a query parameter.
  • Bug Fixes

    • Improved consistency in URI path mapping for services, ensuring correct handling of job resources.

itisallgood avatar Jun 02 '25 16:06 itisallgood

Walkthrough

The _map_service_to_uri method in the Finding class was updated to simplify its logic, always returning "jobs" for job resources and "graphs" otherwise. The get_investigate_uri method was also modified to include the finding's unique identifier in the query parameters for non-job resource kinds.

Changes

File(s) Change Summary
src/robusta/core/reporting/base.py Refactored _map_service_to_uri to simplify URI mapping logic; updated get_investigate_uri to add finding ID to query parameters for non-job kinds.

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant Finding
    participant URI_Generator

    User->>Finding: get_investigate_uri(account_id, cluster_name)
    Finding->>Finding: _map_service_to_uri()
    alt kind is "job"
        Finding->>URI_Generator: Build URI with job parameters
    else kind is not "job"
        Finding->>URI_Generator: Build URI with parameters + finding ID
    end
    URI_Generator-->>Finding: URI string
    Finding-->>User: Investigate URI

📜 Recent review details

Configuration used: CodeRabbit UI Review profile: CHILL Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between e5501ff3d2e70bd2b0c0af122f905a5247045397 and c41d45871a74f7d8fde39078840891e8d79e231b.

📒 Files selected for processing (1)
  • src/robusta/core/reporting/base.py (2 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
  • src/robusta/core/reporting/base.py
⏰ Context from checks skipped due to timeout of 90000ms (2)
  • GitHub Check: run_tests
  • GitHub Check: run_tests
✨ Finishing Touches
  • [ ] 📝 Generate Docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

coderabbitai[bot] avatar Jun 02 '25 16:06 coderabbitai[bot]