krr icon indicating copy to clipboard operation
krr copied to clipboard

Is there a way to support Java and JVM metrics?

Open ErezWeiss opened this issue 1 year ago • 3 comments

Is there a way to support Java and JVM metrics?

So we can see inside the JVM and get recommendations from inside, as it is shown outside the JVM as fully used. Thanks!

ErezWeiss avatar Nov 21 '24 16:11 ErezWeiss

Hey @ErezWeiss

Can you explain what are you trying to achieve? You'd like to see cpu and memory usage of the java process over time? How are you going to use that information?

arikalon1 avatar Nov 25 '24 19:11 arikalon1

Hi @arikalon1 KRR's memory suggestions rely on the general consumption of the container, but Java always allocates it all. The real info is inside the JVM, and I want to get suggestions based on it.

ErezWeiss avatar Nov 25 '24 19:11 ErezWeiss

Thanks for the explanation @ErezWeiss,

KRR supports recommendation strategies. In order to support the above, we need to build a new recommendation strategy, JVMStrategy, and assuming the jvm metrics are in Prometheus, it shouldn't be hard to implement.

I don't think we have availability to implement it right now, but if you're interested in contributing a PR for it, it would be amazing

arikalon1 avatar Nov 25 '24 19:11 arikalon1